Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

fixing #799 (passing in data for confirmSectorProofValid) #1480

Merged
merged 12 commits into from
Sep 23, 2021
Merged

fixing #799 (passing in data for confirmSectorProofValid) #1480

merged 12 commits into from
Sep 23, 2021

Conversation

laudiacay
Copy link
Contributor

@laudiacay laudiacay commented Sep 16, 2021 •
edited
Loading

builds but fails tests. need help w/ fixing tests...

#799

@laudiacay laudiacay marked this pull request as ready for review September 21, 2021 19:30
@laudiacay laudiacay requested a review from a team as a code owner September 21, 2021 19:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #1480 (a45699b) into master (fd2767a) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master   #1480   +/-   ##
======================================
  Coverage    71.4%   71.5%           
======================================
  Files          72      72           
  Lines        8512    8523   +11     
======================================
+ Hits         6084    6095   +11     
  Misses       1545    1545           
  Partials      883     883

ZenGround0
ZenGround0 reviewed Sep 21, 2021
View reviewed changes
actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
@laudiacay laudiacay mentioned this pull request Sep 21, 2021
Closed
ZenGround0
ZenGround0 suggested changes Sep 21, 2021
View reviewed changes
actors/builtin/power/power_test.go Outdated Show resolved Hide resolved
actors/builtin/shared.go Outdated Show resolved Hide resolved
actors/builtin/shared.go Outdated Show resolved Hide resolved
actors/test/commit_post_test.go Outdated Show resolved Hide resolved
actors/test/commit_post_test.go Outdated Show resolved Hide resolved
actors/test/committed_capacity_scenario_test.go Outdated Show resolved Hide resolved
actors/test/committed_capacity_scenario_test.go Outdated Show resolved Hide resolved
actors/test/power_scenario_test.go Show resolved Hide resolved
support/mock/mockrt_state_test.go Outdated Show resolved Hide resolved
test-vectors/.gitignore Outdated Show resolved Hide resolved
@laudiacay laudiacay mentioned this pull request Sep 21, 2021
Open
ZenGround0
ZenGround0 approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor changes

actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
actors/builtin/power/power_actor.go Outdated Show resolved Hide resolved
actors/builtin/power/power_test.go Outdated Show resolved Hide resolved
actors/builtin/power/power_test.go Show resolved Hide resolved
actors/test/commit_post_test.go Show resolved Hide resolved
actors/test/power_scenario_test.go Outdated Show resolved Hide resolved
actors/builtin/power/power_test.go Show resolved Hide resolved
@laudiacay laudiacay merged commit 662d0cf into master Sep 23, 2021
@laudiacay laudiacay deleted the fix-799 branch September 23, 2021 16:29
@ZenGround0 ZenGround0 added this to the Network v14 milestone Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZenGround0 ZenGround0 ZenGround0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Network v14
Development

Successfully merging this pull request may close these issues.
3 participants
@laudiacay @codecov-commenter @ZenGround0